-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Resource Detectors to payment service #651
Merged
puckpuck
merged 6 commits into
open-telemetry:main
from
svrnm:add-resource-detectors-to-payment-service
Dec 24, 2022
Merged
Add Resource Detectors to payment service #651
puckpuck
merged 6 commits into
open-telemetry:main
from
svrnm:add-resource-detectors-to-payment-service
Dec 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <neumanns@cisco.com>
julianocosta89
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: svrnm <neumanns@cisco.com>
mic-max
reviewed
Dec 21, 2022
mic-max
approved these changes
Dec 21, 2022
please fix conflicts, lgtm :) |
fatsheep9146
approved these changes
Dec 22, 2022
Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com>
puckpuck
approved these changes
Dec 24, 2022
This was referenced Dec 27, 2022
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* Add Resource Detectors to payment service Signed-off-by: svrnm <neumanns@cisco.com> * Update CHANGELOG Signed-off-by: svrnm <neumanns@cisco.com> * Update src/paymentservice/package.json Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com> Signed-off-by: svrnm <neumanns@cisco.com> Co-authored-by: Juliano Costa <julianocosta89@outlook.com> Co-authored-by: Michael Maxwell <mike.ian.maxwell@gmail.com> Co-authored-by: Pierre Tessier <pierre@pierretessier.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Like #648 this will add resource detectors to the payment service, to create richer data for the backend, e.g.:
Merge Requirements
CHANGELOG.md
updated to document new feature additions